Enabled target and removed custom trigger

.drone.yml

@@ -30,7 +30,6 @@ volumes:
 trigger:
   event:
     include:
-      - push
       - pull_request
       - custom
 
@@ -51,7 +50,7 @@ steps:
     image: alpine/git
     environment:
       SSH_KEY:
-        from_secret: ssh_key
+        from_secret: private_ssh_key
     commands:
       - mkdir $HOME/.ssh
       - echo "$SSH_KEY" > $HOME/.ssh/id_ed25519
@@ -69,7 +68,7 @@ steps:
       PASSWORD:
         from_secret: docker_password
       SSH_KEY:
-        from_secret: ssh_key
+        from_secret: private_ssh_key
     volumes:
       - name: cache
         path: /home/gradle/.gradle
@@ -81,6 +80,12 @@ steps:
       - chmod 600 $HOME/.ssh/known_hosts
       - ssh-keyscan -H git.2martens.de > $HOME/.ssh/known_hosts 2>/dev/null
       - ./gradlew -Prelease.useLastTag=true final jib
+  - name: promote-staging
+    image: danihodovic/drone-promote
+    settings:
+      drone_token:
+        from_secret: drone_token
+      target: production
 
 volumes:
   - name: cache
@@ -88,10 +93,80 @@ volumes:
       path: /var/lib/drone/cache/.gradle
 
 trigger:
-  branches:
-    - main
   event:
     include:
-      - push
-      - custom
+      - tag
 
+---
+kind: pipeline
+name: deploy image
+type: docker
+
+platform:
+  os: linux
+  arch: arm64
+
+clone:
+  disable: true
+
+steps:
+  - name: clone
+    image: alpine/git
+    environment:
+      SSH_KEY:
+        from_secret: private_ssh_key
+    commands:
+      - mkdir $HOME/.ssh
+      - echo "$SSH_KEY" > $HOME/.ssh/id_ed25519
+      - chmod 600 $HOME/.ssh/id_ed25519
+      - touch $HOME/.ssh/known_hosts
+      - chmod 600 $HOME/.ssh/known_hosts
+      - ssh-keyscan -H git.2martens.de > $HOME/.ssh/known_hosts 2>/dev/null
+      - git clone ssh://giteajim@git.2martens.de:22/2martens/cloud-configuration.git .
+      - git checkout main
+  - name: modify deployed image
+    image: alpine
+    commands:
+      - sed -i -r "s/(wahlrecht_image_version:).*/\1\ ${DRONE_SEMVER}/" ansible/inventories/host_vars/api-server/public.yaml
+  - name: save modified variable file
+    image: alpine/git
+    environment:
+      SSH_KEY:
+        from_secret: private_ssh_key
+    commands:
+      - mkdir $HOME/.ssh
+      - echo "$SSH_KEY" > $HOME/.ssh/id_ed25519
+      - chmod 600 $HOME/.ssh/id_ed25519
+      - touch $HOME/.ssh/known_hosts
+      - chmod 600 $HOME/.ssh/known_hosts
+      - ssh-keyscan -H git.2martens.de > $HOME/.ssh/known_hosts 2>/dev/null
+      - git add ansible/inventories/host_vars/api-server/public.yaml
+      - git diff-index --quiet HEAD || git commit -m "[Drone] Changed wahlrecht_image_version to ${DRONE_SEMVER}"
+      - git push origin main
+  - name: deploy image
+    image: plugins/ansible:latest
+    volumes:
+      - name: cache
+        path: /root/.ansible
+    settings:
+      playbook: ansible/deploy_spring.yaml
+      inventory: ansible/inventories/production
+      galaxy: ansible/requirements.yaml
+      galaxy_force: false
+      private_key:
+        from_secret: private_ssh_key
+      vault_password:
+        from_secret: vault_password
+
+volumes:
+  - name: cache
+    host:
+      path: /var/lib/drone/cache/.ansible
+
+trigger:
+  target:
+    - production
+  event:
+    include:
+      - promote
+      - rollback

.editorconfig

@@ -543,9 +543,9 @@ ij_html_space_inside_empty_tag = false
 ij_html_text_wrap = normal
 
 [{*.kt,*.kts}]
-indent_size = 4
-tab_width = 4
-ij_continuation_indent_size = 8
+indent_size = 2
+tab_width = 2
+ij_continuation_indent_size = 4
 ij_kotlin_align_in_columns_case_branch = false
 ij_kotlin_align_multiline_binary_operation = false
 ij_kotlin_align_multiline_extends_list = false

module-server/src/main/kotlin/de/twomartens/wahlrecht/controller/v1/ElectionController.kt

@@ -12,80 +12,88 @@ import io.swagger.v3.oas.annotations.responses.ApiResponse
 import io.swagger.v3.oas.annotations.security.SecurityRequirement
 import io.swagger.v3.oas.annotations.tags.Tag
 import org.mapstruct.factory.Mappers
-import org.springframework.http.HttpStatus
 import org.springframework.http.MediaType
 import org.springframework.http.ResponseEntity
+import org.springframework.http.ResponseEntity.created
+import org.springframework.http.ResponseEntity.ok
 import org.springframework.web.bind.annotation.*
+import org.springframework.web.util.UriComponentsBuilder
 
 @RestController
 @RequestMapping(value = ["/wahlrecht/v1"])
 @Tag(name = "Elections", description = "all requests relating to elections")
 class ElectionController(private val service: ElectionService) {
-    private val mapper = Mappers.getMapper(ElectionMapper::class.java)
+  private val mapper = Mappers.getMapper(ElectionMapper::class.java)
 
-    @SecurityRequirement(name = "oauth2")
-    @SecurityRequirement(name = "bearerAuth")
-    @GetMapping(value = ["/elections"], produces = [MediaType.APPLICATION_JSON_VALUE])
-    @Operation(
-        summary = "Returns all stored elections",
-        responses = [ApiResponse(
-            responseCode = "200",
-            description = "Returns all stored elections",
-            content = [Content(
-                mediaType = "application/json",
-                array = ArraySchema(
-                    schema = Schema(
-                        implementation = Election::class
-                    )
-                )
-            )]
-        )]
-    )
-    fun getElections(): ResponseEntity<Collection<Election>> {
-            val elections = service.elections.asSequence()
-                .map { mapper.mapToExternal(it.value) }
-                .toList()
-            return ResponseEntity.ok()
-                .contentType(MediaType.APPLICATION_JSON)
-                .body(elections)
-        }
+  @SecurityRequirement(name = "oauth2")
+  @SecurityRequirement(name = "bearerAuth")
+  @GetMapping(value = ["/elections"], produces = [MediaType.APPLICATION_JSON_VALUE])
+  @Operation(
+      summary = "Returns all stored elections",
+      responses = [ApiResponse(
+          responseCode = "200",
+          description = "Returns all stored elections",
+          content = [Content(
+              mediaType = "application/json",
+              array = ArraySchema(
+                  schema = Schema(
+                      implementation = Election::class
+                  )
+              )
+          )]
+      )]
+  )
+  fun getElections(): ResponseEntity<Collection<Election>> {
+    val elections = service.elections.asSequence()
+        .map { mapper.mapToExternal(it.value) }
+        .toList()
+    return ResponseEntity.ok()
+        .contentType(MediaType.APPLICATION_JSON)
+        .body(elections)
+  }
 
-    @Operation(
-        summary = "Returns election matching provided name",
-        responses = [ApiResponse(
-            responseCode = "200",
-            description = "Returns matching election",
-            content = [Content(mediaType = "application/json", schema = Schema(implementation = Election::class))]
-        )]
-    )
-    @GetMapping(value = ["/elections/by-name/{electionName}"], produces = [MediaType.APPLICATION_JSON_VALUE])
-    @SecurityRequirement(name = "bearerAuth")
-    @SecurityRequirement(name = "oauth2")
-    fun getElectionByName(
-        @PathVariable @Parameter(description = "the election name", example = "Bezirkswahl 2019") electionName: String?
-    ): ResponseEntity<Election> {
-        val election = mapper.mapToExternal(service.elections[electionName]!!)
-        return ResponseEntity.ok()
-            .contentType(MediaType.APPLICATION_JSON)
-            .body(election)
-    }
-
-    @Operation(
-        summary = "Stores a new election",
-        responses = [ApiResponse(
-            responseCode = "201",
-            description = "Election was created"
-        ), ApiResponse(responseCode = "200", description = "Election was modified"), ApiResponse(
-            responseCode = "401",
-            description = "Unauthorized",
-            content = [Content(mediaType = "plain/text")]
-        )]
-    )
-    @PutMapping("/election")
-    @SecurityRequirement(name = "bearerAuth")
-    @SecurityRequirement(name = "oauth2")
-    fun putElection(@RequestBody election: Election?): ResponseEntity<*> {
-        val createdNew = service.storeElection(mapper.mapToDB(election!!))
-        return if (createdNew) ResponseEntity<Any>(HttpStatus.CREATED) else ResponseEntity<Any>(HttpStatus.OK)
+  @Operation(
+      summary = "Returns election matching provided name",
+      responses = [ApiResponse(
+          responseCode = "200",
+          description = "Returns matching election",
+          content = [Content(mediaType = "application/json", schema = Schema(implementation = Election::class))]
+      )]
+  )
+  @GetMapping(value = ["/elections/{electionName}"], produces = [MediaType.APPLICATION_JSON_VALUE])
+  @SecurityRequirement(name = "bearerAuth")
+  @SecurityRequirement(name = "oauth2")
+  fun getElectionByName(
+      @PathVariable @Parameter(description = "the election name", example = "Bezirkswahl 2019") electionName: String?
+  ): ResponseEntity<Election> {
+    val election = mapper.mapToExternal(service.elections[electionName]!!)
+    return ok()
+        .contentType(MediaType.APPLICATION_JSON)
+        .body(election)
+  }
+
+  @Operation(
+      summary = "Stores a new election",
+      responses = [ApiResponse(
+          responseCode = "201",
+          description = "Election was created"
+      ), ApiResponse(responseCode = "200", description = "Election was modified"), ApiResponse(
+          responseCode = "401",
+          description = "Unauthorized",
+          content = [Content(mediaType = "plain/text")]
+      )]
+  )
+  @PutMapping("/election")
+  @SecurityRequirement(name = "bearerAuth")
+  @SecurityRequirement(name = "oauth2")
+  fun putElection(@RequestBody election: Election?, uriComponentsBuilder: UriComponentsBuilder):
+      ResponseEntity<Void> {
+    val createdNew = service.storeElection(mapper.mapToDB(election!!))
+    return if (createdNew) {
+      created(uriComponentsBuilder.path("/elections/{electionName}")
+          .buildAndExpand(election.name).toUri())
+          .build()
     }
+    else ok().build()
+  }
 }

module-server/src/main/kotlin/de/twomartens/wahlrecht/controller/v1/ElectionResultController.kt

@@ -14,10 +14,12 @@ import io.swagger.v3.oas.annotations.tags.Tag
 import lombok.RequiredArgsConstructor
 import lombok.extern.slf4j.Slf4j
 import org.mapstruct.factory.Mappers
-import org.springframework.http.HttpStatus
 import org.springframework.http.MediaType
 import org.springframework.http.ResponseEntity
+import org.springframework.http.ResponseEntity.created
+import org.springframework.http.ResponseEntity.ok
 import org.springframework.web.bind.annotation.*
+import org.springframework.web.util.UriComponentsBuilder
 
 @Slf4j
 @RestController
@@ -40,16 +42,16 @@ class ElectionResultController(private val service: ElectionResultService) {
         )]
     )
     @GetMapping(
-        value = ["/electionResult/by-election-name/{electionName}"],
+        value = ["/electionResults/{electionName}"],
         produces = [MediaType.APPLICATION_JSON_VALUE]
     )
     @SecurityRequirement(name = "bearerAuth")
     @SecurityRequirement(name = "oauth2")
-    fun getElectionByName(
+    fun getElectionResultByElectionName(
         @PathVariable @Parameter(description = "the election name", example = "Bezirkswahl 2019") electionName: String
     ): ResponseEntity<ElectionResult> {
         val result = mapper.mapToExternal(service.getElectionResult(electionName))
-        return ResponseEntity.ok()
+        return ok()
             .contentType(MediaType.APPLICATION_JSON)
             .body(result)
     }
@@ -68,8 +70,14 @@ class ElectionResultController(private val service: ElectionResultService) {
     @PutMapping("/electionResult")
     @SecurityRequirement(name = "bearerAuth")
     @SecurityRequirement(name = "oauth2")
-    fun putElection(@RequestBody electionResult: ElectionResult?): ResponseEntity<*> {
+    fun putElection(@RequestBody electionResult: ElectionResult?,
+                    uriComponentsBuilder: UriComponentsBuilder): ResponseEntity<Void> {
         val createdNew = service.storeResult(mapper.mapToDB(electionResult!!))
-        return if (createdNew) ResponseEntity<Any>(HttpStatus.CREATED) else ResponseEntity<Any>(HttpStatus.OK)
+        return if (createdNew) {
+          created(uriComponentsBuilder.path("/electionResult/{electionName}")
+              .buildAndExpand(electionResult.electionName).toUri())
+              .build()
+        }
+        else ok().build()
     }
 }

module-server/src/main/kotlin/de/twomartens/wahlrecht/controller/v1/PartyController.kt

@@ -13,65 +13,103 @@ import io.swagger.v3.oas.annotations.responses.ApiResponse
 import io.swagger.v3.oas.annotations.security.SecurityRequirement
 import io.swagger.v3.oas.annotations.tags.Tag
 import org.mapstruct.factory.Mappers
-import org.springframework.http.HttpStatus
 import org.springframework.http.MediaType
 import org.springframework.http.ResponseEntity
+import org.springframework.http.ResponseEntity.created
+import org.springframework.http.ResponseEntity.ok
 import org.springframework.stereotype.Controller
 import org.springframework.web.bind.annotation.*
+import org.springframework.web.util.UriComponentsBuilder
 
 @Controller
 @RequestMapping(value = ["/wahlrecht/v1"])
 @Tag(name = "Parties", description = "all requests relating to parties")
 class PartyController(private val service: PartyService) {
-    private val mapper = Mappers.getMapper(PartyInElectionMapper::class.java)
-    @Operation(
-        summary = "Returns all stored parties for given election name",
-        responses = [ApiResponse(
-            responseCode = "200",
-            description = "Returns all stored parties",
-            content = [Content(
-                mediaType = "application/json",
-                array = ArraySchema(schema = Schema(implementation = PartyInElection::class))
-            )]
-        ), ApiResponse(
-            responseCode = "404",
-            description = "No parties found",
-            content = [Content(mediaType = "application/json", schema = Schema(implementation = ErrorMessage::class))]
-        )]
-    )
-    @GetMapping(value = ["/parties/by-election-name/{electionName}"], produces = [MediaType.APPLICATION_JSON_VALUE])
-    @SecurityRequirement(name = "bearerAuth")
-    @SecurityRequirement(name = "oauth2")
-    fun getPartiesByElectionName(
-        @PathVariable @Parameter(description = "the election name", example = "Bezirkswahl 2019") electionName: String
-    ): ResponseEntity<Collection<PartyInElection>> {
-        val parties = service.getPartiesByElectionName(electionName).stream()
-            .map { election: de.twomartens.wahlrecht.model.db.PartyInElection? ->
-                mapper.mapToExternal(
-                    election!!
-                )
-            }
-            .toList()
-        return ResponseEntity.ok()
-            .contentType(MediaType.APPLICATION_JSON)
-            .body(parties)
-    }
+  private val mapper = Mappers.getMapper(PartyInElectionMapper::class.java)
 
-    @Operation(
-        summary = "Stores a new party in an election",
-        responses = [ApiResponse(
-            responseCode = "201",
-            description = "Party was created"
-        ), ApiResponse(responseCode = "200", description = "Party was modified"), ApiResponse(
-            responseCode = "401",
-            description = "Unauthorized"
-        )]
+  @Operation(
+      summary = "Returns all stored parties for given election name",
+      responses = [ApiResponse(
+          responseCode = "200",
+          description = "Returns all stored parties",
+          content = [Content(
+              mediaType = "application/json",
+              array = ArraySchema(schema = Schema(implementation = PartyInElection::class))
+          )]
+      ), ApiResponse(
+          responseCode = "404",
+          description = "No parties found",
+          content = [Content(mediaType = "application/json", schema = Schema(implementation = ErrorMessage::class))]
+      )]
+  )
+  @GetMapping(value = ["/parties/{electionName}"], produces = [MediaType.APPLICATION_JSON_VALUE])
+  @SecurityRequirement(name = "bearerAuth")
+  @SecurityRequirement(name = "oauth2")
+  fun getPartiesByElectionName(
+      @PathVariable @Parameter(description = "the election name", example = "Bezirkswahl 2019") electionName: String
+  ): ResponseEntity<Collection<PartyInElection>> {
+    val parties = service.getPartiesByElectionName(electionName).stream()
+        .map { election: de.twomartens.wahlrecht.model.db.PartyInElection? ->
+          mapper.mapToExternal(
+              election!!
+          )
+        }
+        .toList()
+    return ok()
+        .contentType(MediaType.APPLICATION_JSON)
+        .body(parties)
+  }
+
+  @Operation(
+      summary = "Returns stored party for given election name and party abbreviation",
+      responses = [ApiResponse(
+          responseCode = "200",
+          description = "Returns stored party",
+          content = [Content(
+              mediaType = "application/json",
+              schema = Schema(implementation = PartyInElection::class)
+          )]
+      ), ApiResponse(
+          responseCode = "404",
+          description = "No party found",
+          content = [Content(mediaType = "application/json", schema = Schema(implementation = ErrorMessage::class))]
+      )]
+  )
+  @GetMapping(value = ["/parties/{electionName}/{abbreviation}"], produces = [MediaType.APPLICATION_JSON_VALUE])
+  @SecurityRequirement(name = "bearerAuth")
+  @SecurityRequirement(name = "oauth2")
+  fun getPartyByElectionNameAndAbbreviation(
+      @PathVariable @Parameter(description = "the election name", example = "Bezirkswahl 2019") electionName: String,
+      @PathVariable @Parameter(description = "the party abbreviation", example = "SPD") abbreviation: String
+  ): ResponseEntity<PartyInElection> {
+    val party = mapper.mapToExternal(
+        service.getPartyByElectionNameAndAbbreviation(electionName, abbreviation)
     )
-    @PutMapping("/party")
-    @SecurityRequirement(name = "bearerAuth")
-    @SecurityRequirement(name = "oauth2")
-    fun putParty(@RequestBody party: PartyInElection?): ResponseEntity<*> {
-        val createdNew = service.storeParty(mapper.mapToDB(party!!))
-        return if (createdNew) ResponseEntity<Any>(HttpStatus.CREATED) else ResponseEntity<Any>(HttpStatus.OK)
-    }
+    return ok()
+        .contentType(MediaType.APPLICATION_JSON)
+        .body(party)
+  }
+
+  @Operation(
+      summary = "Stores a new party in an election",
+      responses = [ApiResponse(
+          responseCode = "201",
+          description = "Party was created"
+      ), ApiResponse(responseCode = "200", description = "Party was modified"), ApiResponse(
+          responseCode = "401",
+          description = "Unauthorized"
+      )]
+  )
+  @PutMapping("/party")
+  @SecurityRequirement(name = "bearerAuth")
+  @SecurityRequirement(name = "oauth2")
+  fun putParty(@RequestBody party: PartyInElection?,
+               uriComponentsBuilder: UriComponentsBuilder): ResponseEntity<Void> {
+    val createdNew = service.storeParty(mapper.mapToDB(party!!))
+    return if (createdNew) {
+      created(uriComponentsBuilder.path("/parties/{electionName}/{abbreviation}")
+          .buildAndExpand(party.electionName, party.abbreviation).toUri())
+          .build()
+    } else ok().build()
+  }
 }

module-server/src/main/kotlin/de/twomartens/wahlrecht/property/ServiceProperties.kt

@@ -2,11 +2,13 @@ package de.twomartens.wahlrecht.property
 
 import io.swagger.v3.oas.annotations.media.Schema
 import org.springframework.boot.context.properties.ConfigurationProperties
-import org.springframework.boot.context.properties.bind.ConstructorBinding
 import org.springframework.cloud.context.config.annotation.RefreshScope
 import java.time.ZoneId
 
 @RefreshScope
 @ConfigurationProperties(prefix = "de.twomartens.wahlrecht")
 @Schema(description = "Properties, to configure this Application")
-data class ServiceProperties @ConstructorBinding constructor(val defaultTimeZone: ZoneId, val greeting: String)
+class ServiceProperties {
+    lateinit var defaultTimeZone: ZoneId
+    lateinit var greeting: String
+}

module-server/src/main/kotlin/de/twomartens/wahlrecht/repository/PartyRepository.kt

@@ -5,4 +5,6 @@ import org.springframework.data.mongodb.repository.MongoRepository
 
 interface PartyRepository : MongoRepository<PartyInElection, String> {
     fun findByElectionName(name: String): Collection<PartyInElection>
+
+    fun findByElectionNameAndAbbreviation(electionName: String, abbreviation: String): PartyInElection?
 }

module-server/src/main/kotlin/de/twomartens/wahlrecht/service/PartyService.kt

@@ -18,6 +18,13 @@ class PartyService(
         fetchParties()
     }
 
+  fun getPartyByElectionNameAndAbbreviation(electionName: String,
+                                            abbreviation: String): PartyInElection {
+    return partyRepository.findByElectionNameAndAbbreviation(electionName, abbreviation)
+        ?: throw ResponseStatusException(HttpStatus.NOT_FOUND,
+            "no party found for $electionName and $abbreviation")
+  }
+
     fun getPartiesByElectionName(electionName: String): Collection<PartyInElection> {
         val parties = partyRepository.findByElectionName(electionName)
         if (parties.isEmpty()) {

module-server/src/main/resources/application-prod.yaml

@@ -1,5 +1,7 @@
 spring:
   config:
     import:
-      - "classpath:config/wahlrecht.yaml"
-      - "optional:configserver:http://configserver:8888/config"
+      - "configserver:http://configserver:8888/config"
+  kafka:
+    bootstrap-servers:
+      - kafka:9092

module-server/src/main/resources/application.yaml

@@ -28,10 +28,6 @@ spring:
       name: wahlrecht
   main:
     banner-mode: off
-  kafka:
-    bootstrap-servers:
-      - localhost:9092
-      - kafka:9092
   profiles:
     default: dev
   data.mongodb:

module-server/src/main/resources/config/wahlrecht-prod.yaml

@@ -1,2 +1,2 @@
 de.twomartens.wahlrecht:
-  greeting: "Moin %s, you are prod"
+  greeting: "Moin %s, you are test"