fix: Prevent endless loop

2024-06-09 11:12:47 +02:00
parent 6c13815fc3
commit 6add2baa40
1 changed files with 6 additions and 1 deletions
@@ -247,6 +247,7 @@ class CalculationService(
        var assignedSeats: Long
        var assignedSeatsPerVotingResult: Map<VotingResult, Int>
        log.debug("Calculate assigned seats with initial election number {}", electionNumber)
+        var numberOfAttempts = 5
        do {
            electionNumberHistory.add(electionNumber)
            val seatsPerVotingResult: MutableMap<VotingResult, Double> = mutableMapOf()
@@ -277,7 +278,11 @@ class CalculationService(
                )
                log.debug("Calculated higher election number {}", electionNumber)
            }
-        } while (assignedSeats != numberOfSeats.toLong())
+            numberOfAttempts--
+        } while (assignedSeats != numberOfSeats.toLong() && numberOfAttempts > 0)
+        if (numberOfAttempts == 0 && assignedSeats != numberOfSeats.toLong()) {
+          log.error("With the given result, the solution can never be calculated")
+        }
        return assignedSeatsPerVotingResult
    }